-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstraction for LO frequency to MWChannel that matches the IQChannel #75
Abstraction for LO frequency to MWChannel that matches the IQChannel #75
Conversation
Thanks for the PR @deanpoulos, I think we'll need something like this, but let's think a bit about which properties need to be shared. We may also want to share other properties such as |
Sure thing @nulinspiratie. This is a minimal change to unblock ~5 calibration nodes at the moment. |
@deanpoulos the changes you propose should be added to QuAM, but I would like to merge it once it also has |
…req_mw_channel_abstraction
Hey @nulinspiratie so you will take it from here? |
Thanks for the reminder! Will aim to have it ready for review first half of this week |
@deanpoulos added Only had time to add a basic test, will add more at some point in the future, but not in this PR |
Looking into it today @nulinspiratie |
Hey @nulinspiratie, I went initialized a QuAM with your fix included for flux-tunable qubits, and ran through the regular post-processing on one of the calibration nodes using dummy data. I can confirm that it worked without error, and the post-processing (frequency updates) worked as expected. I think this is good enough to merge for now, and we will obviously test it further in the field with real data. |
For OPX+/OPX1000 dynamic code, we would like the
IQChannel
andMWChannel
to share a common interface for accessing the upconverter frequency field.Although this approach matches the convention used in the
IQChannel
, I'm indifferent to how the property looks at the end of the day, as long as the upconverter frequency can be accessed the same way between both channel types.@nulinspiratie @KevinAVR